Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle input gracefully in keybinding editKey ui function #951

Merged
merged 1 commit into from
Jul 12, 2018

Conversation

commy2
Copy link
Contributor

@commy2 commy2 commented Jul 3, 2018

When merged this pull request will:

  • Ignore vanilla input, i.e. don't close the menu if you assign a keyaction to Num Enter, Enter; don't change control focus when assigning a keyaction to Tab etc.
  • the call is needed, because due to a bug, return values in eventhandlers are ignored if they come from exitWith in the main scope of the eventhandler script.

Needs testing, don't have access to Arma the next two weeks.

@commy2 commy2 added this to the 3.8 milestone Jul 3, 2018
@commy2
Copy link
Contributor Author

commy2 commented Jul 4, 2018

Tested, works.

Copy link
Contributor

@BaerMitUmlaut BaerMitUmlaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@commy2 commy2 merged commit 3687f67 into master Jul 12, 2018
@commy2 commy2 deleted the editKeyGUIImprovement branch July 12, 2018 19:56
ViperMaul added a commit that referenced this pull request Jul 27, 2018
* origin/master:
  XEH - Compatiblity for Encore (1.84) (#953)
  indicate settings that need a mission restart (#894)
  don't skip next PFH if current one is removed while iterating through (#950)
  change color of name of temporarily changed settings (#952)
  handle input gracefully in keybinding editKey ui function (#951)
  Update fnc_deleteEntity.sqf (#949)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants